Skip to content

bug: min. temperature values changed in 2.21 IronOS #182

Closed
@River-Mochi

Description

@River-Mochi

To Reproduce
Steps to reproduce the behaviour:

  • 2.21 IronOS made changes to the temp min/maxes due to a typo or conversion error from a long time ago that was only recently noticed.

  • Turns out the min temp of 60F was incorrect for all irons since 10C minimum = 50F and not 60F. but we only care about pinecil here.

  • I will submit pr fix if I have time, but whoever gets to this first is welcome to fix it and close this ticket. literally this ticket prob took me 100 times longer to write than changing the 60F to a 50F >.<

This file needs to be updated:
https://github.com/builder555/PineSAM/blob/master/backend/pinecil_setting_limits.py

Screenshots
image

Original IronOS Issue ticket
Error was reported and I submitted a fix for it here: Ralim/IronOS#1624

Reference this IronOS code file here:
https://github.com/Ralim/IronOS/blob/0a4560efac961e5f5fbe47d5f9d7beb78dc77d4a/source/Core/BSP/Pinecilv2/configuration.h#L132-L137

  • PineSAM Version: all
  • IronOS build/date: 2.21

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions