Prepare soci-store to be linked into and run by the executor #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimberezniker
approved these changes
Aug 28, 2023
| @@ -124,14 +118,24 @@ func (kc *keychain) GetCredentials(host string, refspec reference.Spec) (string, | |||
| return "", "", nil | |||
| } | |||
|
|
|||
| func Keychain(ctx context.Context) *keychain { | |||
| func Keychain(ctx context.Context, port int) *keychain { | |||
There was a problem hiding this comment.
nit: I would call this func Init
There was a problem hiding this comment.
Good call, done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes so that the soci-store can be run in-process as a goroutine in the executor:
configobject rather than referenced directly.local_keychainport flag specification into main (we can get rid of the grpc service after it's running in-process too).Mount()function return the fuse server so it can be unmounted directly on SIGINT.