Add stages to the firecracker_stage_duration_usec metric #8281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will save a tiny bit of time, but that's not the main reason I'm making the change. Currently, the FirecrackerExecDialDurationUsec metric records the time for 3 dials per action. The first dial is much slower, but the 2nd and 3rd one drive down the average for the metric, so it seems that the par action dial is faster than it really is.
I added the `pull_image` and `remote` stages, and I split `init` into `create` and `unpause`.
bduffany
approved these changes
Feb 3, 2025
enterprise/server/remote_execution/containers/firecracker/firecracker.go
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added the
pull_imageandremovestages, and I splitinitintocreateandunpause.