Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: readme #8697

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

docs: readme #8697

wants to merge 3 commits into from

Conversation

Olexandr88
Copy link

@Olexandr88 Olexandr88 commented Dec 11, 2024

The previous link did not work

Proposed changes

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@Olexandr88 Olexandr88 requested a review from a team as a code owner December 11, 2024 10:36
@SanjoDeundiak
Copy link
Member

Hey @Olexandr88 , thanks for noticing the broken link! In order to merge this PR could you please do the following:

  1. Change the link to https://aws.amazon.com/marketplace/pp/prodview-m3url7jixicii (without url arguments)
  2. Go through the checks and finish these:

@Olexandr88
Copy link
Author

Hey Oleksandr Deundiak please check

@SanjoDeundiak
Copy link
Member

@Olexandr88 could you please accept the CLA (Contributor License Agreement)? Instructions are in my previous comment, also in your PR description

@Olexandr88
Copy link
Author

I'm sorry, but I don't understand something, how to sign the CLA

@SanjoDeundiak
Copy link
Member

@Olexandr88 - to accept Contributor License Agreement you need to add your Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@SanjoDeundiak SanjoDeundiak mentioned this pull request Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants