Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: kafka example readmes are more precise in their descriptions #7921

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ckhrysze
Copy link
Member

Current behavior

Kafka docs refer to client

Proposed changes

Kafka docs refer to producers and consumers

Checks

  • All commits in this Pull Request are signed and Verified by Github.
  • All commits in this Pull Request follow the Ockam commit message convention.
  • There are no Merge commits in this Pull Request. Ockam repo maintains a linear commit history. We merge Pull Requests by rebasing them onto the develop branch. Rebasing to the latest develop branch and force pushing to your Pull Request branch is okay.
  • I have read and accept the Ockam Community Code of Conduct.
  • I have read and accepted the Ockam Contributor License Agreement by adding my Git/Github details in a row at the end of the CONTRIBUTORS.csv file in a separate pull request to the build-trust/ockam repository. The easiest way to do this is to edit the CONTRIBUTORS.csv file in the github web UI and create a separate Pull Request, this will mark the commit as verified.

@ckhrysze ckhrysze requested a review from a team as a code owner April 17, 2024 14:04
# We connect a kafka client in one virtual private network with a Redpanda event streamer
# in another virtual private network.
# We connect a kafka producer and consumer in one virtual private network with a Redpanda
# event streamer in another virtual private network.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# event streamer in another virtual private network.
# in another virtual private network.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants