test: fix 3 typecheck failures blocking all PR merges (PKT-565)

[bugsyhewitt]

Summary

Fixes 3 pre-existing TypeScript typecheck errors on main that are causing the TypeScript typecheck CI gate to fail on every open PR. Zero production code changes.

Blocked PRs unblocked by this fix: 30+ open PRs with auto-merge-ok label, including #418–#448.

Defects fixed

Defect 1 (TS2769) — governance-loop-handleJobFailed-legacy.test.ts lines 191, 238
([state]: [string]) => in a .filter() callback fails TypeScript 7.x because any[] (the inferred type of mock.calls elements) is not assignable to [string] (a 1-tuple). Fixed by moving the tuple annotation inside the body as a cast:

// before
(call): boolean => { const [state] = call as [string]; return state === 'AWAITING_ADVICE'; }

Defect 2 (TS2345) — hierarchy-bootstrap-online-fitness.test.ts line 153
The getRegistry mock was missing bestForTool and size (added to RegistryStore after this test was authored in PKT-295). RegistryStore has private store/toolIndex fields so an object literal cannot satisfy it structurally — the fix adds the missing public members and uses as unknown as ReturnType<typeof getRegistry>, the only correct pattern for class types with private fields.

Defect 3 (TS2345) — test/utils.test.ts:200
Only existed in a dirty working tree from prior cycles; not present on clean main. Not applicable to this branch.

Evidence

• Baseline: pnpm exec tsc --noEmit exits 1 with 3 errors on clean main
• After fix: exits 0, no output
• Vitest: 138 test files, 2188/2234 tests passed (46 skipped) — unchanged
• Binding review: APPROVED by alienclaw-architect (no blocking items)

Refs

• Packet: PKT-565
• Related CI failure: affects PR fix(api/server): exact-equality routing for GET /v1/genomes/top (PKT-533) #443, fix(api): guard /v1/install catch against non-JSON Error.message (PKT-530 / PKT-472 regression) #441, fix(api): guard validateInstallRequest against null/undefined + wrap install catch JSON.parse (PKT-472) #405, fix(api): exact-match /v1/genomes/top router predicate — drop startsWith over-match (PKT-491) #418–fix(reflective): plumb slot_count from CostRecord — computeLegacyScalar / rawObjectiveVector (PKT-542) #448 and 25+ others

🤖 Generated with Claude Code