PIPE-8933 xcode26 fix #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bullmo
previously approved these changes
Oct 10, 2025
|
|
||
| StringRef compDir = StringRef(unitForOffset->getCompilationDir()); | ||
|
|
||
| // XCode26 dSYMs compiled with global first units, detected by "/" compilation directory of the first compile unit |
There was a problem hiding this comment.
It's probably worth updating this comment to get a bit more generic (otherwise when looking at this in the future it might seem as though it was just an issue with v26 of XCode)
bullmo
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue for dSYMs built with XCode26.
We have some old logic that takes the first compile unit to get the compilation directory and makes filenames relative to that if applicable. The newer version of xcode is building dSYMs where the first CU has a compilation directory of '/'
We can't just switch to use relative paths as it would break existing groupings (where compilation directory is different from the project compilation directory e.g. libraries)
This change intends to target XC26 dSYMs by identifying the compilation directory of '/' in the first CU and in that case return a relative path for the filename of returned symbol. This is a change in behaviour, but it seems more correct for all paths to be relative to the CU. There may be some regrouping in included libraries but will fix the already broken file groupings.
See https://github.com/bugsnag/bugsnag-dsym/pull/38 for test
Note: I manually tested an apple library file path and it was unchanged behaviour.