Release v4.6.0 #363
Merged
Release v4.6.0 #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously you had to manage the delegate being None if one didn't already exist in the current context. This made the API a bit awkward as every use of it required the same check & creation of a new delegate Now the delegate is created in ContextLocalState directly so users don't need to worry about it possibly returning None
This should be 'featureFlag', not 'name'
There's no event loop when we call 'get_event_loop' in this test, which works fine as it creates a new one anyway but now emits a deprecation warning Creating a new event loop fixes the deprecation without changing the test's behaviour
See the warning in the docs: https://setuptools.pypa.io/en/latest/pkg_resources.html
tomlongridge
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancements
Add support for feature flags & experiments
#350
#351
Remove use of deprecated
pkg_resourcesmodule#362