Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for level parameter in constructor #249

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ForroKulcs
Copy link

Goal

logging.Handler supports level parameter. This change is to enable forwarding this value.

Design

level is introduced as first parameter as it is also the first parameter of logging.Handler

Changeset

constructor declaration was changed

Testing

manual local test was used

@johnkiely1
Copy link
Member

Hi @ForroKulcs .

Thanks for the PR, this sounds like a good idea. We will review in due course.

@johnkiely1 johnkiely1 added backlog We hope to fix this feature/bug in the future feature request Request for a new feature labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog We hope to fix this feature/bug in the future feature request Request for a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants