Improve span timoeut handling in BugsnagNativeSpansPlugin #678
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Improves the handling of span timoeut timers in
BugsnagNativeSpansPlugin
NSTimer
for handling span timeouts inBugsnagNativeSpansPlugin
Design
the
NSTimer
based span timeout timers were occasionally not firing for some tracked spans (network spans) that are not ended, due to run loop issues. This was causing memory leaks due to timeout timers not firing being removed. This PR switches to using GCD for span timeout timers, which avoids the issue and also has lower overheadsIn addition, span timeout timers for a given span are now removed if a new span with the same name is started, avoiding holding references to untracked spans unnecessarily
Testing
Tested manually