Skip to content

Make MetadataFilters case insensitive #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025
+3 −1
Merged

Make MetadataFilters case insensitive #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Bugsnag/Serializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
Expand All @@ -15,7 +16,7 @@ public static string SerializeObject(object obj)
public static string SerializeObject(object obj, string[] filters)
{
var parsedFilters = filters != null ?
filters.ToDictionary(m => m, m => true) :
filters.ToDictionary(m => m, m => true, StringComparer.OrdinalIgnoreCase) :
new Dictionary<string, bool>();

try
Expand Down
1 change: 1 addition & 0 deletions tests/Bugsnag.Tests/SerializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ public static IEnumerable<object[]> FilterTestData()
yield return new object[] { new FilterableTestObject { { "password", "password" } }, null, 0 };
yield return new object[] { new FilterableTestObject { { "username", "password" } }, new string[] { "password" }, 0 };
yield return new object[] { new FilterableTestObject { { "password", "password" }, { "credit_card_number", "number" } }, new string[] { "password", "credit_card_number" }, 2 };
yield return new object[] { new FilterableTestObject { { "Password", "password" }, { "Credit_Card_Number", "number" } }, new string[] { "password", "credit_card_number" }, 2 };
}
}
}