Set maxBreadcrumbs via Configuration rather than Client #359
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Provides
config.setMaxBreadcrumbs
in favour ofclient.setMaxBreadcrumbs
, which is now deprecated.Changeset
client.setMaxBreadcrumbs
andBugsnag.setMaxBreadcrumbs
maxBreadcrumbs
property toConfiguration
BreadcrumbsTest
to Kotlin, documenting what each test case attempts to verify, and adding new testsTests
Ran unit tests, mazerunner locally, performed manual testing on dashboard around breadcrumb limits. Added new unit tests for accessor behaviour, and documented existing tests.
Review
For the submitter, initial self-review:
For the pull request reviewer(s), this changeset has been reviewed for: