Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnrLinkError and NdkLinkError report #2070

Merged
merged 1 commit into from
Aug 16, 2024
Merged

AnrLinkError and NdkLinkError report #2070

merged 1 commit into from
Aug 16, 2024

Conversation

YYChen01988
Copy link
Contributor

Goal

Improve AnrLinkError and NdkLinkError report so when loading our native libraries.

Changeset

Error reporting added to metadata when loading library

Testing

Existing unit tests

@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Aug 16, 2024 •
edited
Loading

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1853.94 1674.72
arm64_v8a 631.04 450.82
armeabi_v7a 565.51 385.29
x86 708.85 528.62
x86_64 676.09 495.86

Generated by 🚫 Danger

@YYChen01988 YYChen01988 force-pushed the PLAT-12412/anrlinkerror-and-ndklinkerror-reporting branch from 9666e0c to 82f74d2 Compare August 16, 2024 09:33
@YYChen01988 YYChen01988 merged commit 2f5a951 into next Aug 16, 2024
34 checks passed
@YYChen01988 YYChen01988 deleted the PLAT-12412/anrlinkerror-and-ndklinkerror-reporting branch August 16, 2024 09:45
This was referenced Sep 25, 2024
Closed
Merged
blaztinn added a commit to blaztinn/bugsnag-android that referenced this pull request Jan 9, 2025
@blaztinn
feat(report): add NdkLinkError to metadata (bugsnag#2070)
aae85b9 
Commit 2f5a951 added metadata to AnrLinkError but didn't to NdkLinkError.

Copy the solution from AnrLinkError to NdkLinkError.
@blaztinn blaztinn mentioned this pull request Jan 9, 2025
Closed
@YYChen01988 YYChen01988 mentioned this pull request Jan 20, 2025
Merged
YYChen01988 added a commit that referenced this pull request Jan 21, 2025
@YYChen01988 @blaztinn
add NdkLinkError to metadata (#2126)
10d7d68 
* feat(report): add NdkLinkError to metadata (#2070)

Commit 2f5a951 added metadata to AnrLinkError but didn't to NdkLinkError.

Copy the solution from AnrLinkError to NdkLinkError.

* chore(changelog) change log for pr

---------

Co-authored-by: Blaž Tomažič <blaz.tomazic@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomlongridge tomlongridge tomlongridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YYChen01988 @bugsnagbot @tomlongridge