Reinstate instrumentation tests using MacOS test boxes as a platform #2034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
|
It's probably worth using the |
Cawllec
force-pushed
the
tests/instrumentation-reinstatement
branch
2 times, most recently
from
86ccfff to
ef9a54b
Compare
Cawllec
force-pushed
the
tests/instrumentation-reinstatement
branch
from
ef9a54b to
7c16ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
We've had to remove our instrumentation tests from github actions for a variety of reasons. This change adds a script which should add Android Virtual Devices and SDKs to our MacOS test boxes as required, using them to run the instrumentation tests. The version of android we're testing against is determined by the API_LEVEL environment variable, which should allow us to run against several different API levels if we see the need to.
Testing
It's successfully completed several test runs, and a negative test run to ensure the script failed successfully.