Don't copy FeatureFlags on the crashing thread #2005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-11866/copy-on-write-feature-flags
branch
from
d003ab6 to
8943350
Compare
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
approved these changes
Apr 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Avoid making defensive copies of the feature flags on the notifying thread (unless they are altered in an
OnErrorCallback).Design
Replaced the
LinkedHashMapwith a Copy-On-Write data structure. To avoid multiple levels of locking, and the need for iterators this is a simple encapsulated array which is copied each time a change is required.The new implementation is slower when adding & removing feature flags (since each addition or removal is now O(n) rather than O(1)), but since there are relatively few feature flags added per run (<1000) this should be a reasonable trade-off as now the feature flags do not need any synchronization or defensive copying when an error report is required.
Testing
Additional tests for the new implementation and existing tests still pass.