Support regexes for redacted keys and discard classes in android #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android notifier sizes
Generated by 🚫 Danger |
ghost
force-pushed
the
PLAT-4222_Support_regexes_for_redactedKeys_and_discardClasses_in_Android
branch
from
7008ce9 to
b130a24
Compare
lemnik
deleted the
PLAT-4222_Support_regexes_for_redactedKeys_and_discardClasses_in_Android
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Offer a more flexible way to specify discard classes and redacted keys in order to reduce the boiler-plate for customers with large numbers of either.
Changeset
Redacted keys and discard classes are now a
Set<Pattern>instead ofSet<String>offering a more flexible API.Testing
Updated the existing tests to use the new API