Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run any ANR scenarios on Samsungs #1834

Merged
merged 2 commits into from
Apr 21, 2023
Merged

Conversation

twometresteve
Copy link
Contributor

Goal

No not run any ANR scenarios on Samsungs.

Design

Follow on to #1831, not all ANR scenarios were considered.

Testing

Covered by CI.

@twometresteve twometresteve requested a review from lemnik April 21, 2023 07:51
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Apr 21, 2023

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1921.49 1696.72
arm64_v8a 680.33 459.15
armeabi_v7a 614.8 393.62
x86 754.04 532.86
x86_64 725.38 504.19

Generated by 🚫 Danger

Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@twometresteve twometresteve changed the title No not run any ANR scenarios on Samsungs Do not run any ANR scenarios on Samsungs Apr 21, 2023
@twometresteve twometresteve merged commit d51d006 into next Apr 21, 2023
@twometresteve twometresteve deleted the tms/skip-samsung branch April 21, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants