Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDK set up for apple silicon #1828

Merged
1 commit merged into from
Apr 11, 2023
Merged

JDK set up for apple silicon #1828

1 commit merged into from
Apr 11, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 11, 2023

Goal

Added note for setting up JDK version for apple silicon

Testing

Manual test

@ghost ghost requested a review from lemnik April 11, 2023 10:07
@bugsnagbot
Copy link
Collaborator

bugsnagbot commented Apr 11, 2023 •
edited
Loading

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1921.33 1696.73
arm64_v8a 680.33 459.15
armeabi_v7a 614.8 393.62
x86 754.04 532.86
x86_64 725.38 504.19

Generated by 🚫 Danger

@ghost ghost force-pushed the SmartbearYing/Enviroment_note_update_for_apple_silicon branch from b573276 to 6e1e0d4 Compare April 11, 2023 10:37
lemnik
lemnik approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@lemnik lemnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost merged commit 0808bc3 into next Apr 11, 2023
@ghost ghost deleted the SmartbearYing/Enviroment_note_update_for_apple_silicon branch April 11, 2023 11:14
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugsnagbot @lemnik @YYChen01988