Delete persisted NDK events earlier in delivery process #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
changed the title
fractalwrench
force-pushed
the
PLAT-6188/delete-ndk-file-early
branch
from
fb71f99 to
4f65e83
Compare
fractalwrench
force-pushed
the
PLAT-6188/delete-ndk-file-early
branch
from
4f65e83 to
a704907
Compare
Android notifier sizes
Generated by 🚫 Danger |
kstenerud
approved these changes
Dec 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Deletes persisted NDK events as soon as they are read back into a
bsg_eventstruct. This avoids the chance of a crash loop happening ifNativeInterface.deliverReport()throws an exception.Testing
Relied on existing E2E test coverage.