fix(lowMemory): align the app.lowMemory field for JVM and NDK #1342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemnik
force-pushed
the
PLAT-7107/consistent-lowMemory-reporting
branch
4 times, most recently
from
782d404 to
6184f98
Compare
kattrali
approved these changes
Aug 16, 2021
bugsnag-android-core/src/main/java/com/bugsnag/android/ClientComponentCallbacks.kt
Outdated
Show resolved
Hide resolved
| @@ -340,6 +340,7 @@ public Unit invoke(String oldOrientation, String newOrientation) { | |||
| }, new Function1<Boolean, Unit>() { | |||
| @Override | |||
| public Unit invoke(Boolean isLowMemory) { | |||
| appDataCollector.setLowMemory(isLowMemory == Boolean.TRUE); | |||
There was a problem hiding this comment.
Should this be checking the value of the instance instead of equality with the static constant? I highly doubt this would end up with a constructed Boolean() instance but still.
Suggested change
| appDataCollector.setLowMemory(isLowMemory == Boolean.TRUE); | |
| appDataCollector.setLowMemory(isLowMemory.booleanValue()); |
lemnik
force-pushed
the
PLAT-7107/consistent-lowMemory-reporting
branch
from
6184f98 to
31d74f8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
The
app.lowMemoryattribute should be reported in the same way for all errors.Design
Cache the most recent value sent to
ComponentCallbacks.onLowMemoryandComponentCallbacks2.onTrimMemoryin theAppDataCollectorand report that value instead of looking-up the value at crash-time.When we receive a trim memory event that indicates any state less than COMPLETE we set the cached lowMemory state to
false.Testing
Manual testing for both native and JVM crashes, and a new unit test to cover the mapping between memory-trim values and the
lowMemoryflag.