Skip to content

Conversation

fractalwrench
Copy link
Contributor

Goal

Adds projectPackages to the event payload. This is used to improve deobfuscation when a class in the projectPackages package has been minified with ProGuard - inProject calculations do not work well here as the class name will be mangled.

Testing

  • Added unit tests to ensure projectPackages is serialized
  • Updated smoke tests to add E2E assertions
  • Tested errors sent in obfuscated example app

@fractalwrench fractalwrench force-pushed the PLAT-6389/project-packages branch from aeec30c to fb1f86a Compare April 21, 2021 09:17
@fractalwrench fractalwrench marked this pull request as ready for review April 21, 2021 09:45
@fractalwrench fractalwrench changed the title Add projectPackages to event payload Add projectPackages field to error payloads Apr 21, 2021
@fractalwrench fractalwrench force-pushed the PLAT-6389/project-packages branch from fb1f86a to d8e8e8a Compare April 21, 2021 09:46
@bugsnagbot
Copy link
Collaborator

Android notifier sizes

Format Size impact of Bugsnag (kB) Size impact of Bugsnag when Minified (kB)
APK 1514.08 1414.46
arm64_v8a 402.18 299.78
armeabi 381.69 279.29
armeabi_v7a 365.32 262.92
x86 439.02 336.62
x86_64 422.64 320.24

Generated by 🚫 Danger

@fractalwrench fractalwrench merged commit d8e8e8a into next Apr 21, 2021
@fractalwrench fractalwrench deleted the PLAT-6389/project-packages branch April 21, 2021 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants