Add cpu abi to device information #119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| cpuAbi = Abi2Wrapper.getAbi1andAbi2(); | ||
| } | ||
|
|
||
| return cpuAbi; |
There was a problem hiding this comment.
This method can be simplified to
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) {
return SupportedAbiWrapper.getSupportedAbis();
}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.FROYO) {
return Abi2Wrapper.getAbi1andAbi2();
}
return Build.CPU_ABI;Also is it worth wrapping Build.CPU_ABI in an array so that the output format is always consistent regardless of API level?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the CPU/ABI information to the device information as suggested in #109
This is done slightly differently to ensure that the tests pass on android v4