Remove duplicate fields #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…getting the name is not duplicated
…gic for getting the name is not duplicated" This reverts commit 9428d71.
lemnik
pushed a commit
that referenced
this pull request
Jun 2, 2021
rich-bugsnag
pushed a commit
that referenced
this pull request
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are a couple of constructors for the Error object, one takes and exception and the other takes a name, message and stacktrace.
These fields are store separately and every time the details are accessed we have to check which one to use.
This PR adds a new BugsnagException class used to wrap the name, message and stacktrace so that can store them in the exception field.