Ensure proguard files are included in AAR #1096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomlongridge
approved these changes
Jan 27, 2021
Android notifier sizes
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Ensures that proguard.txt is added to AARs so that consumers of the library can use ProGuard and R8 for obfuscation.
Changeset
Alters the gradle script so that each module declares the
consumerProguardFiles, rather than setting it in an afterEvaluate closure. The AGP version used to build the project has recently changed, so it seems probable that newer versions of AGP read this information before theafterEvaluateblock triggers, thus ignoring the consumer proguard file.Testing
Confirmed that a locally generated AAR contains a proguard.txt file with the appropriate contents, and checked that the deployed artefact does not.
https://developer.android.com/studio/projects/android-library#aar-contents