Prevent potential SHA-1 hash mismatch in Bugsnag-Integrity header for session requests #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fractalwrench
force-pushed
the
PLAT-5579/integrity-header-sessions
branch
from
12add8b to
b77cbaa
Compare
Android notifier sizes
Generated by 🚫 Danger |
tomlongridge
requested changes
Dec 11, 2020
bugsnag-android-core/src/main/java/com/bugsnag/android/Session.java
Outdated
Show resolved
Hide resolved
…r for session requests
fractalwrench
force-pushed
the
PLAT-5579/integrity-header-sessions
branch
from
b77cbaa to
f3a6703
Compare
tomlongridge
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal
Prevents a SHA-1 hash mismatch when the React Native notifier changes the
notifierfield on startup. Because the Android notifier assigns the event payload value by reference fromClient#notifier, the request payload can change between generating a SHA-1 hash and making the request.Changeset
Copied the
notifierparameter when constructing aSession, so that it does not hold a copy of global state.Testing
Added unit test to verify that the
notifierproperty is always copied when constructing aSession.