Implementation of simple consent #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zomglings
requested changes
Apr 23, 2021
| @@ -2,6 +2,38 @@ | |||
| This module implements Humbug's user consent mechanisms. | |||
| */ | |||
|
|
|||
| type Yes = "1" | "t" | "y" | "T" | "Y" | "true" | "yes" | "True" | "Yes" | "TRUE" | "YES" | |||
javascript/src/consent.ts
Outdated
| } | ||
| } | ||
|
|
||
| function environmentVariableOptOut(): boolean { |
There was a problem hiding this comment.
BUGGER_OFF=true is not for libraries integrating with humbug, it is for the end user.
If someone who is using humbug in their library wants to have environmentVariableOptOut, we should implement similiarly as in humbug/python.
There was a problem hiding this comment.
This should instead be like this:
function environmentVariableOptOut(envVar: string, optOutValues: Array<string>): func():bool {
return func(): bool {
const envVal = process.env[envVar];
return optOutValues.includes(envVal);
}
}| } | ||
|
|
||
| check(): boolean { | ||
| if (this.mechanisms === false) { |
There was a problem hiding this comment.
if (Yes.includes(process.env.BUGGER_OFF)) {
return false;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.