Use of DCD for "Go To Definition" and Code Completion functionality plus other changes. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses DCD to get location. See issue buggins#5
See issue buggins#20 Suggestions is not displayed yet.
| @@ -245,7 +271,7 @@ class SimpleDSyntaxHighlighter : SyntaxHighlighter { | |||
| for (;;) { | |||
| ch = nextBracket(dir, p); | |||
| if (!ch) // no more brackets | |||
| return startPos; | |||
| break; | |||
There was a problem hiding this comment.
This caused a compiler issue for me at the last return in the function: "Statement is not reachable".
…pletion item Also set focus back to editor after completion popup
Freakazo
changed the title
|
automatic merge is impossible |
|
Could you please merge to latest mainstream? |
|
Merged. It compiles and runs, but I didn't check new functionality |
|
Did some refactoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Okay so this is all the changes I've made to fix #20 and fix #5.
There is still a fair bit to do, but I believe this is ready to be merged in.
So firstly I've created a new directory for tools, such as Go to Def and Code Completion. In the hope that the IDE in the future can also be used for other languages, I've created the EditorTool class which will contain abstract methods. We then implement those abstract methods for each language inside a folder with the name of the language. DEditorTool implements those methods and uses DCDInterface to start dcd-client to send the requests to dcd-server. I want to re-implement dcd-client so that we can talk directly to dcd-server through sockets, which should be a big boon to performance for very large documents. However I'm completely unsure of the legality of doing so.
I've also moved SimpleDSyntaxHighlighter out of dsourceedit.d into its own file under tools.
Right now I've assigned Go to Def as SHIFT+G and for Code Completion CTRL+SHIFT+G.
Make sure that dcd-client is in your path and that dcd-server is running.
There still is a fairly lengthy todo list, which I'll get to work on as soon as I get feedback for the changes.
Still to do:
Fix caret disappearing after insertion.Refactor extprocess so that we have access to stdin.
Handle the user continueing to type, display only matches containing entered text.
Inform user when dcd-client command is not found.
Check that dcd-server is running and attempt to start it if it is not, if we started it we should also kill it.
Let the user know when we don't know of any completions or we don't know where the symbol declaration is.
I've only tested this on Linux at the moment.
Please review and let me know what I should change.