Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment ports for concurrent procs #1

Merged

Conversation

rwc9u
Copy link

@rwc9u rwc9u commented Sep 24, 2020

What does it do?

  • Adds procNum to the port calculation for startProc
  • Adds TestStartProc

What else do you need to know?

  • The current implementation maintains the same port when concurrency is added. This change increments the port count by 1 similar to the original foreman and node foreman.

Example

Procfile

web: node app.js
-bash  ~/dev/helloexpress  ⬙ 2.5.3p105  ⬢ system
rchristie@greed    ~/go/src/forego/forego start -c web=2
forego | starting web.1 on port 5000
forego | starting web.2 on port 5001
web.2  | Example app listening at http://localhost:5001
web.1  | Example app listening at http://localhost:5000
^C      | ctrl-c detected
forego | sending SIGTERM to web.1
forego | sending SIGTERM to web.2

@bugficks bugficks merged commit 85a1e90 into bugficks:master Mar 1, 2021
@bugficks
Copy link
Owner

bugficks commented Mar 1, 2021

@rwc9u
Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants