Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MAX_MARKDOWN_SIZE to 100kb #47

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Update MAX_MARKDOWN_SIZE to 100kb #47

merged 2 commits into from
Feb 21, 2019

Conversation

ticky
Copy link
Contributor

@ticky ticky commented Feb 21, 2019

Buildkite’s maximum annotation size is now 100kb, so this can be adjusted to suit!

ticky added 2 commits February 21, 2019 13:05
@ticky
Update MAX_MARKDOWN_SIZE to 100kb
a2931da 
Buildkite’s maximum annotation size is now 100kb, so this can be adjusted to suit!
@ticky
Update note about truncation limits in Readme
8e44c44
@ticky ticky marked this pull request as ready for review February 21, 2019 21:08
tessereth
tessereth reviewed Feb 21, 2019
View reviewed changes
Copy link
Contributor

@tessereth tessereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request!

Assuming the max size has changed, this LGTM. I just need to check this is correct. Out of curiosity, how did you know this had changed?

@ticky
Copy link
Contributor Author

ticky commented Feb 21, 2019

I work at Buildkite and realised we never made noise about it 😅

@tessereth
Copy link
Contributor

Ah. Well thanks for fixing this!

@tessereth tessereth merged commit bfa9c27 into bugcrowd:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tessereth tessereth tessereth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ticky @tessereth