fix(acp): emit newline separator between consecutive status updates#998
Merged
fix(acp): emit newline separator between consecutive status updates#998
Conversation
Each Status loopback event now emits a leading newline chunk before the status text so that consecutive calls (matching skills / building context / thinking) accumulate as separate lines rather than a single concatenated string in the ACP thought bubble. Closes #988
bug-ops
force-pushed
the
fix/988-acp-status-replace
branch
from
6fa5ec7 to
aa4701d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LoopbackEvent::Statusnow emits twoAgentThoughtChunkevents: a\nseparator and the status text.matching skills…,building context…,thinking…) from concatenating into a single line in the ACP thought bubble.loopback_status_maps_to_thoughttest (now expects 2 chunks instead of 1) and addedloopback_status_updates_show_as_separate_linestest.Test plan
cargo nextest run -p zeph-acp --lib -E 'test(loopback_status)'— 2 tests passcargo +nightly fmt --check— cleancargo clippy -p zeph-acp -- -D warnings— cleanCloses #988