fix(acp): replace direct send with send_tool_output in skill streaming paths#987
Merged
fix(acp): replace direct send with send_tool_output in skill streaming paths#987
Conversation
…g paths Skill execution paths (direct output and confirmation-required) were calling channel.send(format_tool_output(...)) directly, embedding the tool header as plain text. Both paths now call channel.send_tool_output so that LoopbackChannel emits a structured ToolOutput event with separate tool_name and display fields, enabling ACP consumers (Zed) to render a proper tool card. Fixes #985.
bug-ops
force-pushed
the
worktree-fix/985-acp-tool-output
branch
from
b66d9dc to
ecbda43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_execution.rswere callingchannel.send(format_tool_output(...))directlychannel.send_tool_output(...), emitting a structuredLoopbackEvent::ToolOutputwith separatetool_nameanddisplayfieldsfilter_stats_inlineis forwarded as a structured field in the direct-output pathTest plan
cargo clippy -p zeph-core -- -D warningspasses with zero warningscargo nextest run -p zeph-core --lib— all 766 tests pass[tool output: name]headerFixes #985.