feat(acp): implement P0 protocol gaps G2, G3, G4, G8#948
Merged
Conversation
github-actions
bot
added
enhancement
bug-ops
force-pushed
the
feat/acp-930-mcp-transport
branch
from
fb6ac36 to
cbfeb36
Compare
G2: add set_session_mode handler that validates session existence and
returns SetSessionModeResponse; unknown sessions return an error.
G3: advertise config_options and ext_methods support in AgentCapabilities
via meta fields on the initialize response.
G4: override ext_notification to log method name at debug level and
return Ok(()) instead of the default method_not_found error.
G8: extend mcp_bridge to convert Http and Sse McpServer variants to
McpTransport::Http entries instead of silently skipping them.
SSE is mapped to Streamable HTTP since rmcp handles both.
Closes #930
Document new ACP capabilities: MCP HTTP/SSE transport (G8), set_session_mode (G2), ext_notification (G4), AgentCapabilities meta fields (G3).
bug-ops
force-pushed
the
feat/acp-930-mcp-transport
branch
from
cbfeb36 to
4f165c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpandSseACP server variants toMcpTransport::Httpentries instead of silently skipping them. SSE maps to Streamable HTTP since rmcp'sStreamableHttpClientTransporthandles both.AgentCapabilitiesin theinitializeresponse now advertisesconfig_optionsandext_methodssupport via meta fields.ext_notificationhandler override logs method name at debug level and returnsOk(())instead ofmethod_not_found.set_session_modehandler validates session existence and returnsSetSessionModeResponse; unknown sessions returninvalid_request.G1 (SDK upgrade): no action needed —
agent-client-protocol 0.9.4is already the latest stable.Test plan
cargo nextest run -p zeph-acp— 104 tests, all passcargo clippy --workspace -- -D warnings— zero warningscargo +nightly fmt --check— cleanconverts_http_server,converts_sse_server,mixed_list_returns_alltests inmcp_bridgeext_notification_accepts_unknown_methodtest inagentset_session_mode_returns_ok_for_valid_sessionandset_session_mode_returns_error_for_unknown_sessiontests