perf(memory): covering index on messages and load_history_filtered CTE refactor#911
Merged
perf(memory): covering index on messages and load_history_filtered CTE refactor#911
Conversation
github-actions
bot
added
performance
bug-ops
force-pushed
the
feat/864-db-optimization
branch
from
968e83f to
a8324e5
Compare
…uery Add composite index (conversation_id, id) on messages table via migration 015, replacing the single-column index for filter+order access patterns used by oldest_message_ids and load_history_filtered. Replace the double-sort subquery in load_history_filtered with a CTE, eliminating the redundant ORDER BY on the derived table. Closes #895, closes #896, part of #864.
Document covering index (conversation_id, id) and load_history_filtered CTE refactor in docs/architecture/performance.md and zeph-memory README.
bug-ops
force-pushed
the
feat/864-db-optimization
branch
from
a8324e5 to
952c5ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #895, closes #896, part of #864.
Changes
Migration 015 — adds composite covering index
(conversation_id, id)onmessagestable, replacing the single-columnconversation_idindex. Eliminates the post-filter sort step foroldest_message_idsandload_history_filteredaccess patterns.load_history_filtered— replaces double-sort subquery (ORDER BY id DESC LIMIT+ outerORDER BY id ASC) with a CTE. Query semantics are identical; the CTE makes the intent explicit and gives the SQLite optimizer a cleaner execution plan.Test plan
cargo clippy -p zeph-memory -- -D warnings— cleancargo nextest run -p zeph-memory --lib --features mock— 279 passed, 2 skippedcargo +nightly fmt --check— clean