security(tools): SSRF redirect chain defense (#857)#908
Merged
Conversation
…on tests Add 20 tests covering manual redirect following in WebScrapeExecutor: unit tests for hop counting, missing Location, status errors, URL resolution, and validate_url guards on each redirect target; wiremock integration tests exercising 1-hop, 3-hop allowed, 4-hop rejected, no Location, oversized body, and non-2xx status against a real HTTP server. docs: update security.md, tools.md, zeph-tools/README.md and root README with SSRF redirect chain defense documentation.
github-actions
bot
added
size/XL
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reqwest::redirect::Policy::limited(3)withPolicy::none()inWebScrapeExecutorfetch_htmlLocationtarget is passed throughvalidate_url+resolve_and_validatebefore the next connection — blocking private/internal IP redirect targetsTest plan
crates/zeph-tools/src/scrape.rs10.x,192.168.x,127.x,::1) blocked viavalidate_urlhttp://scheme blocked.internal/.localdomain blockedLocationheader → errormax_body_bytes→ errorcargo nextest run -p zeph-tools→ 510/510 passedcargo clippy --workspace -- -D warnings→ cleancargo +nightly fmt --check→ clean