security(tools): harden shell sandbox against process substitution and here-string bypass#907
Merged
security(tools): harden shell sandbox against process substitution and here-string bypass#907
Conversation
…d here-string bypass (#870) - Add <(, >(, <<<, eval to ShellConfig default confirm_patterns - Document find_blocked_command limitations in doc comment - Add 14 tests: known-limitation units, confirm_patterns coverage, async executor confirmations - Update config default snapshot, docs, and README
github-actions
bot
added
documentation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #870 (part of epic #856).
<(,>(,<<<,evaltoShellConfigdefaultconfirm_patterns— these patterns now trigger confirmation before execution instead of running silentlyfind_blocked_commanddocumenting known bypass limitations (process substitution, here-strings, eval, variable expansion) with examplessecurity.md,configuration.md,tools.md), and README filesTest plan
cargo +nightly fmt --check— passcargo clippy --workspace -- -D warnings— 0 warningscargo nextest run --workspace --lib --bins— 2771 passed