refactor(core): extract ContextManager, ToolOrchestrator, LearningEngine from Agent#900
Merged
refactor(core): extract ContextManager, ToolOrchestrator, LearningEngine from Agent#900
Conversation
github-actions
bot
added
documentation
…ine from Agent Break the Agent god object into focused subsystems with clear ownership: - ContextManager: owns budget/compaction config, token_counter, should_compact() and prune logic (replaces ContextState) - ToolOrchestrator: owns doom_loop_history, max_iterations, overflow_config, is_doom_loop() detection - LearningEngine: owns learning config and reflection state, is_enabled()/check_improvement_allowed() methods Agent delegates to these structs via thin wrappers. No behavior change, all 2693 tests pass unmodified. Closes #836, closes #837, closes #838 Part of #830
…ningEngine docs(arch): update crates.md and overview.md for agent decomposition docs(readme): add new agent subsystems to zeph-core README 17 new unit tests covering: - ToolOrchestrator: doom loop detection, hash push/clear, boundary cases - LearningEngine: reflection lifecycle, is_enabled with config variants - ContextManager: should_compact with/without budget, threshold, empty messages
bug-ops
force-pushed
the
feat/830-agent-decomposition
branch
from
ae251e8 to
6e36618
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ContextManagerfrom Agent — owns budget/compaction config,token_counter,should_compact()(replacesContextState)ToolOrchestrator— owns doom loop history, max iterations, overflow config,is_doom_loop()detectionLearningEngine— owns learning config and reflection state,is_enabled()/check_improvement_allowed()Test plan
cargo +nightly fmt --checkpassescargo clippy --workspace -- -D warningspasses (0 warnings)cargo nextest run --workspace --lib --bins— 2693 passed, 9 skippedCloses #836, closes #837, closes #838
Part of #830