fix(acp): flush on error and filter whitespace text blocks in Claude API#828
Merged
fix(acp): flush on error and filter whitespace text blocks in Claude API#828
Conversation
github-actions
bot
added
bug
When process_response() fails (e.g. 529 overloaded), the error handler sends the error message but never flushes, leaving the ACP drain loop waiting indefinitely. Move flush_chunks() after the error block so it runs on both success and failure paths.
bug-ops
force-pushed
the
fix/acp-flush-on-error
branch
from
09837a1 to
9b6c10a
Compare
…ude API Skip messages with agent_visible=false in split_messages and split_messages_structured to prevent sending hidden context to the API. Guard all text content blocks against whitespace-only content which Claude API rejects with 400 "text content blocks must contain non-whitespace text".
bug-ops
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flush_chunks()inside error handler inhandle_text()so ACP sessions recover from LLM errors (529 overloaded, timeouts) without double-flushing on success pathagent_visible=falseinsplit_messagesandsplit_messages_structuredto prevent sending hidden context to Claude APITest plan