fix(acp): deduplicate tool definitions and flush after native tool loop#827
Merged
fix(acp): deduplicate tool definitions and flush after native tool loop#827
Conversation
CompositeExecutor.tool_definitions() now deduplicates by tool id (first-wins), preventing Claude API 400 "Tool names must be unique". process_response_native_tools() now calls flush_chunks() on all exit paths, so the ACP session correctly transitions back to idle and accepts subsequent prompts.
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bashexecutorsflush_chunks()on all exit paths (Text response and loop break), so the ACP session correctly emits aFlushevent and transitions back to idle — fixing "prompt already in progress" on subsequent requestsTest plan
cargo clippy --workspace -- -D warningspassescargo nextest run --workspace --lib --bins— 2691 passed