feat(acp): HTTP+SSE and WebSocket transport#826
Merged
Conversation
Add HTTP+SSE and WebSocket transports to the ACP server alongside existing stdio. Axum-based POST /acp returns SSE stream, GET /acp reconnects SSE notifications, GET /acp/ws upgrades to WebSocket. Session routing via Acp-Session-Id header with UUID validation. Includes body size limits (1 MiB), WS message size limits, max_sessions enforcement (503), CORS deny-all, idle reaper with last_activity tracking, SSE keepalive pings. Feature-gated behind acp-http. Adds AcpTransport enum and http_bind config fields. Closes #783
github-actions
bot
added
rust
core
dependencies
enhancement
github-actions
bot
added
the
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/acpaccepts JSON-RPC, returns SSE stream; GET/acpreconnects SSE notifications withAcp-Session-Idheader/acp/wsupgrades to bidirectional WebSockettransport.rsintotransport/module (stdio.rs, bridge.rs, http.rs, ws.rs, router.rs)tokio::io::duplexconnects axum handlers to ACP SDK'sAsyncRead+AsyncWritevia dedicated OS thread withLocalSet(required for!SendAgent)last_activitytracking viaAtomicU64acp-http; addsAcpTransportenum andhttp_bindto[acp]configTest plan
--features acp-http)--features fullCloses #783