feat(acp): rich content support — images, resources, tool locations#822
Merged
feat(acp): rich content support — images, resources, tool locations#822
Conversation
Multi-modal ACP prompts: image content blocks decoded from base64 and forwarded to LLM providers as attachments. Embedded resource text wrapped in <resource> markers and appended to prompt. Tool output now includes optional file locations for IDE navigation via ToolCallLocation. Security hardening: 20 MiB base64 size guard, MIME whitelist (jpeg/png/gif/webp), resource text isolation markers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements Epic #784 — Rich Content Support for ACP.
4.1 Multi-modal prompts
<resource>markers and appended to prompt4.2 Tool locations
LoopbackEvent::ToolOutputextended withlocations: Option<Vec<String>>acp::ToolCallLocationfor IDE file navigation4.3 Thinking chunks
Security hardening
Test plan
Closes #784