feat(acp): transport wiring, config, manifest, integration tests#776
Merged
feat(acp): transport wiring, config, manifest, integration tests#776
Conversation
Wire ACP transport to real IDE connection via ConnSlot pattern. Add [acp] config section with ZEPH_ACP_* env overrides. Extract serve_connection<W,R> for testability. Read IDE capabilities from InitializeRequest for file executor. Add --acp-manifest CLI flag for agent registry. Add --init wizard ACP section. Integration tests via tokio::io::duplex (initialize + session lifecycle). Closes #770, closes #771, closes #772, closes #773
github-actions
bot
added
documentation
The --acp-manifest flag added a 4th bool to the Cli struct, triggering the lint. CLI arg structs are inherently bool-heavy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConnSlotpattern withserve_connection<W,R>extraction for testability[acp]config section in zeph-core withZEPH_ACP_*env overrides and--initwizard integrationInitializeRequestfor file executor permission flags--acp-manifestCLI flag printing agent manifest JSON for registry discoverytokio::io::duplexcovering initialize handshake and session lifecycleCloses #770, closes #771, closes #772, closes #773
Test plan
cargo +nightly fmt --check— passcargo clippy --workspace -- -D warnings— passcargo nextest run --workspace --lib --bins— 2554 passedcargo nextest run -p zeph-acp— 42 passed (including 2 new integration tests)