feat(acp): IDE-proxied file system, terminal, permissions, MCP passthrough#775
Merged
feat(acp): IDE-proxied file system, terminal, permissions, MCP passthrough#775
Conversation
…rough Add Phase 2 IDE capabilities to zeph-acp: - fs.rs: AcpFileExecutor implementing ToolExecutor for read_file/write_file proxied through IDE via ACP Client trait, with path traversal validation - terminal.rs: AcpShellExecutor implementing ToolExecutor for bash commands proxied through IDE terminal lifecycle (create/wait/output/release), with permission gate integration - permission.rs: AcpPermissionGate with session-scoped tool_name cache for AllowAlways/RejectAlways decisions, mpsc+oneshot bridge pattern - mcp_bridge.rs: convert IDE-provided MCP server configs (stdio) to zeph-mcp ServerEntry format - agent.rs: AcpContext struct, updated AgentSpawner signature to accept Option<AcpContext> for IDE adapter injection - error.rs: ClientError, CapabilityUnavailable, ChannelClosed variants Closes #767, #768, #769, #770
This was
linked to
issues
Feb 23, 2026
Use platform-conditional test paths (C:\tmp\ on Windows, /tmp/ on Unix) to fix validate_absolute_path rejection on Windows where Unix paths are not recognized as absolute.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 of ACP integration — IDE-proxied capabilities for
zeph-acpcrate:fs.rs—AcpFileExecutorimplementingToolExecutorforread_file/write_fileproxied through IDE via ACP Client trait, with absolute path validation and traversal rejectionterminal.rs—AcpShellExecutorimplementingToolExecutorforbashcommands proxied through IDE terminal lifecycle (create/wait/output/release), with permission gate integrationpermission.rs—AcpPermissionGatewith session-scopedtool_namecache forAllowAlways/RejectAlwaysdecisions,mpsc+oneshotbridge pattern for!Sendconn accessmcp_bridge.rs— convert IDE-provided MCP server configs (stdio transport) tozeph-mcpServerEntryformatagent.rs—AcpContextstruct, updatedAgentSpawnersignature to acceptOption<AcpContext>error.rs—ClientError,CapabilityUnavailable,ChannelClosedvariantsArchitecture
All adapters use channel bridge pattern (
mpscsender inSendcontext,LocalSetreceiver callsAgentSideConnectionmethods,oneshotreply):Known limitation
transport.rsconn-sharing wiring (spawningLocalSethandlers withRc<AgentSideConnection>) is deferred — adapters are implemented and tested but not yet connected to the real connection. This will be completed in Phase 3 alongside integration tests (#773).Closes #767, #768, #769, #770
Test plan
cargo nextest run -p zeph-acp)cargo clippy --workspace -- -D warningscleancargo +nightly fmt --checkclean