fix(memory): auto-create parent directories for sqlite_path#757
Merged
Conversation
SqliteStore::new() now calls create_dir_all on the parent directory before opening the database connection, preventing startup failures when the configured path (e.g. ./data/zeph.db) has missing parent directories. Closes #756
github-actions
bot
added
bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SqliteStore::new()now callscreate_dir_allon the parent directory before opening the SQLite connectionIovariant toMemoryErrorforstd::io::Errorpropagationdata/directory does not exist (default config uses./data/zeph.db)Test plan
creates_parent_dirstest — verifies nested directory creationcargo +nightly fmt --check— passcargo clippy --workspace -- -D warnings— passcargo nextest run -p zeph-memory --lib --features mock— 253/253 passCloses #756