Conversation
…treaming, and ToolCallLocation Closes #1007. Implements three ACP protocol extensions that make subagent activity visible in IDE clients (Zed, VS Code ACP extension). parent_tool_use_id propagation (#1008): - Add parent_tool_use_id to LoopbackEvent::ToolStart/ToolOutput in channel.rs - Add with_parent_tool_use_id() builder on Agent<C> and AgentBuilder - tool_execution.rs passes parent_tool_use_id through all send_tool_start/ send_tool_output call sites - loopback_event_to_updates injects _meta.claudeCode.parentToolUseId into ACP ToolCall and ToolCallUpdate notifications; null for top-level agent, UUID for subagents - All Channel implementors (AnyChannel, AppChannel, TuiChannel) updated Terminal streaming (#1009): - AcpShellExecutor::execute_in_terminal refactored to use stream_until_exit helper that polls output every 200ms via tokio::select! - Emits ToolCallUpdate with _meta.terminal_output per chunk during execution - Emits ToolCallUpdate with _meta.terminal_exit on completion - UTF-8 safety: byte-offset slice replaced with str::get() + unwrap_or("") ToolCallLocation (#1010): - Add locations: Option<Vec<String>> to ToolOutput in zeph-tools - AcpFileExecutor populates locations with absolute file path for read_file and write_file branches - Channel::send_tool_output trait extended with locations parameter; LoopbackChannel forwards it instead of hardcoding None - tool_execution.rs extracts out.locations and passes through at all 3 call sites; loopback_event_to_updates forwards to ToolCall.location Tests added: loopback_tool_start/output_parent_tool_use_id_injected_into_meta, streaming_mode_emits_terminal_exit_notification, read/write_file_returns_location, handle_tool_result_locations_propagated_to_loopback_event (2950 pass total) Documentation: README.md, crates/zeph-acp/README.md, docs/src/advanced/acp.md updated with wire protocol details and IDE setup guidance.
This was
linked to
issues
Feb 27, 2026
bug-ops
added a commit
that referenced
this pull request
Feb 27, 2026
Add docs/src/guides/ide-integration.md covering ACP stdio setup, Zed and VS Code configuration, and the three subagent visibility features from PR #1014: subagent nesting via parent_tool_use_id, live terminal streaming via AcpShellExecutor, and agent following via ToolCallLocation. Update docs/src/SUMMARY.md and CHANGELOG.md. Closes #1011
bug-ops
added a commit
that referenced
this pull request
Feb 27, 2026
Add docs/src/guides/ide-integration.md covering ACP stdio setup, Zed and VS Code configuration, and the three subagent visibility features from PR #1014: subagent nesting via parent_tool_use_id, live terminal streaming via AcpShellExecutor, and agent following via ToolCallLocation. Update docs/src/SUMMARY.md and CHANGELOG.md. Closes #1011
bug-ops
added a commit
that referenced
this pull request
Feb 27, 2026
…#1015) Add docs/src/guides/ide-integration.md covering ACP stdio setup, Zed and VS Code configuration, and the three subagent visibility features from PR #1014: subagent nesting via parent_tool_use_id, live terminal streaming via AcpShellExecutor, and agent following via ToolCallLocation. Update docs/src/SUMMARY.md and CHANGELOG.md. Closes #1011
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1007, #1008, #1009, #1010.
Summary
Implements three ACP protocol extensions that make subagent activity visible in IDE clients (Zed, VS Code ACP extension), bringing Zeph to parity with the
zed-industries/claude-agent-acpreference.session_updatecarries_meta.claudeCode.parentToolUseId; IDEs nest subagent output under the parent tool call cardAcpShellExecutorstreams bash output in real time via_meta.terminal_outputchunks and_meta.terminal_exiton completionToolCall.locationcarriesfilePathfor file read/write operations; IDE editor cursor follows the agentChanges
zeph-acpagent.rs,fs.rs,terminal.rszeph-corechannel.rs,agent/mod.rs,agent/builder.rs,agent/tool_execution.rszeph-toolsexecutor.rs+ 6 implementorszeph-channels,zeph-tui, rootany.rs,channel.rsTest plan
cargo +nightly fmt --check— passcargo clippy --workspace -- -D warnings— pass (0 warnings)cargo nextest run --workspace --lib --bins— 2950 passed, 11 skippedloopback_tool_start/output_parent_tool_use_id_injected_into_meta,streaming_mode_emits_terminal_exit_notification,read/write_file_returns_location,handle_tool_result_locations_propagated_to_loopback_event