-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Labels
acpAgent Client Protocol integrationAgent Client Protocol integrationenhancementNew feature or requestNew feature or requestsize/M
Milestone
Description
Parent Epic
Problem
In main.rs, _acp_ctx is discarded in the spawner closure. AcpFileExecutor, AcpShellExecutor, and AcpPermissionGate are constructed but never used.
Solution
- Accept
AcpContextinspawn_acp_agent()andbuild_acp_deps() - When
AcpContext.file_executorisSome, use it instead of local file tools - When
AcpContext.shell_executorisSome, use it instead ofShellExecutor - When
AcpContext.permission_gateisSome, wrap tool execution with permission checks - Integrate via
CompositeExecutoror a newAcpToolExecutorwrapper
Critical Path
No dependencies — can start immediately.
Blocks: #780 (cancellation), Epic 2 (#778)
Acceptance Criteria
-
AcpContextparameter used (not discarded) in spawner - IDE FS read/write proxied when capability advertised
- IDE shell execution proxied when capability advertised
- Permission gate wraps tool calls when capability advertised
- Fallback to local tools when IDE capability not advertised
- Tests with mock ACP client verifying tool delegation
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
acpAgent Client Protocol integrationAgent Client Protocol integrationenhancementNew feature or requestNew feature or requestsize/M