fix(lsp): await background init task on shutdown#203
Open
ebbsanchez wants to merge 1 commit into
Open
Conversation
Author
|
CI note: I checked the current failures. The CodeQL jobs fail before analyzing this patch because the Local verification for the patch is still:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the shutdown path introduced by non-blocking LSP startup by keeping the background initialization task handle and awaiting it with a bounded timeout after cancellation is sent.
This keeps
serve_withnon-blocking during startup, but makes shutdown observe the background task instead of dropping theJoinHandle. If the task panics, it is now logged; if it does not stop promptly, shutdown logs a timeout and continues.Type of Change
Related Issues
Fixes #196
Checklist
Verification
cargo +nightly fmt --checkcargo test -p mcpls-core graceful_degradation_tests -- --nocapturecargo clippy -p mcpls-core --all-targets --all-features -- -D warningsAdditional Notes
I did not update
CHANGELOG.mdbecause this is an internal shutdown/diagnostic behavior fix without a user-facing CLI/API change.