fix(lib): use absolute workspace path with canonicalization#16
Merged
Conversation
- Extract resolve_workspace_roots() helper function - Use std::env::current_dir() instead of relative "." - Canonicalize paths to prevent symlink-based traversal - Add graceful fallback on errors with warnings - Add 3 unit tests for workspace root resolution Fixes rust-analyzer "LSP server process terminated unexpectedly" when no explicit workspace roots are configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_workspace_roots()helper that usesstd::env::current_dir()with canonicalizationProblem
When no workspace roots were configured, mcpls used
PathBuf::from(".")which resulted infile://.being sent to LSP servers. rust-analyzer and other LSP servers don't handle relative URIs, causing "LSP server process terminated unexpectedly" errors.Solution
Extract workspace root resolution into a dedicated helper function that:
std::env::current_dir()to get the absolute pathTest plan
cargo clippy --all-targets --all-features -- -D warningspassescargo +nightly fmt --checkpassesReview Notes