perf: optimize SafePath::validate canonicalization (50% faster)#53
Merged
perf: optimize SafePath::validate canonicalization (50% faster)#53
Conversation
Add ValidationContext with 3-layer optimization to eliminate redundant canonicalize() syscalls during path validation: 1. Skip parent canonicalize when parent is in DirCache (created by us) 2. Skip all canonicalize when archive has no symlinks and config disallows them 3. Full canonicalize fallback for archives with symlinks Results: validation 12 us -> 6 us per entry, extraction throughput +20-25% for many-files workloads. All security properties preserved. Closes #51
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #53 +/- ##
==========================================
+ Coverage 90.08% 90.36% +0.28%
==========================================
Files 61 58 -3
Lines 10013 10180 +167
==========================================
+ Hits 9020 9199 +179
+ Misses 993 981 -12
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate redundant
canonicalize()syscalls inSafePath::validatevia a 3-layerValidationContextoptimization:parent.canonicalize()when parent is in DirCache (created by extraction engine)Results
Security
canonicalize()runs unconditionally when symlinks are presentTest plan
Closes #51