server/schedule: fix invalid store id (tikv#5315)

close tikv#5279

fix invalid store id

Signed-off-by: LLThomas <zs033@qq.com>

Co-authored-by: 混沌DM <hundundm@gmail.com>

server/schedule/operator_controller.go

@@ -479,8 +479,8 @@ func (oc *OperatorController) addOperatorLocked(op *operator.Operator) bool {
 	for storeID := range opInfluence.StoresInfluence {
 		store := oc.cluster.GetStore(storeID)
 		if store == nil {
-			log.Error("invalid store ID", zap.Uint64("store-id", storeID))
-			return false
+			log.Info("missing store", zap.Uint64("store-id", storeID))
+			continue
 		}
 		for n, v := range storelimit.TypeNameValue {
 			storeLimit := store.GetStoreLimit(v)

server/schedule/operator_controller_test.go

@@ -780,3 +780,23 @@ func (suite *operatorControllerTestSuite) TestAddWaitingOperator() {
 	// no space left, new operator can not be added.
 	suite.Equal(0, controller.AddWaitingOperator(addPeerOp(0)))
 }
+
+// issue #5279
+func (suite *operatorControllerTestSuite) TestInvalidStoreId() {
+	opt := config.NewTestOptions()
+	tc := mockcluster.NewCluster(suite.ctx, opt)
+	stream := hbstream.NewTestHeartbeatStreams(suite.ctx, tc.ID, tc, false /* no need to run */)
+	oc := NewOperatorController(suite.ctx, tc, stream)
+	// If PD and store 3 are gone, PD will not have info of store 3 after recreating it.
+	tc.AddRegionStore(1, 1)
+	tc.AddRegionStore(2, 1)
+	tc.AddRegionStore(4, 1)
+	tc.AddLeaderRegionWithRange(1, "", "", 1, 2, 3, 4)
+	steps := []operator.OpStep{
+		operator.RemovePeer{FromStore: 3, PeerID: 3, IsDownStore: false},
+	}
+	op := operator.NewTestOperator(1, &metapb.RegionEpoch{}, operator.OpRegion, steps...)
+	suite.True(oc.addOperatorLocked(op))
+	// Although store 3 does not exist in PD, PD can also send op to TiKV.
+	suite.Equal(pdpb.OperatorStatus_RUNNING, oc.GetOperatorStatus(1).Status)
+}