Merged
Conversation
ghost
The publish workflow is yelling at us because we're including "263 files out of which 200 are JavaScript files. For performance reasons, you should bundle your extension". This attempts to do that, following the linked guide with the esbuild approach, alongside some minor tweaks. The biggest additions in LoC here are just the `esbuild` and `npm-run-all` dependencies (following along the guide). We could probably drop the `npm-run-all` if we want to skip including the `watch` script targets in package.json, 🤷. This should be validated by the tests, which load up the extension. Ref: https://github.com/bufbuild/vscode-buf/actions/runs/21229578613 Ref: https://code.visualstudio.com/api/working-with-extensions/bundling-extension
stefanvanburen
force-pushed
the
svanburen/bundle-extension
branch
from
557d236 to
fbe83af
Compare
doriable
previously approved these changes
Jan 22, 2026
In package.json, we switched around the `package` script to run the actual `esbuild` command to create the dist/ output, _not_ run `vsce package` as it previously did. `vsce package` will run `package` because of the `vscode:prepublish` script, but we want to update the Makefile to do the same thing it did previously (build the `.vsix` file) and the publish workflow to do the same.
Member
Author
doriable
approved these changes
Jan 22, 2026
stefanvanburen
added a commit
that referenced
this pull request
Jan 27, 2026
This reverts commit 5d717cf. We discovered a couple of issues using the bundled extension with WSL; backing this out for now until we can track down issues.
stefanvanburen
added a commit
that referenced
this pull request
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish workflow is yelling at us because we're including "263 files out of which 200 are JavaScript files. For performance reasons, you should bundle your extension". This attempts to do that, following the linked guide with the esbuild approach, alongside some minor tweaks.
The biggest additions in LoC here are just the
esbuildandnpm-run-alldependencies (following along the guide). We could probably drop thenpm-run-allif we want to skip including thewatchscript targets in package.json, 🤷.This should be validated by the tests, which load up the extension.
Ref: https://github.com/bufbuild/vscode-buf/actions/runs/21229578613
Ref: https://code.visualstudio.com/api/working-with-extensions/bundling-extension